UnsafePinned: implement opsem effects of UnsafeUnpin#151365
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Feb 15, 2026
Merged
UnsafePinned: implement opsem effects of UnsafeUnpin#151365rust-bors[bot] merged 2 commits intorust-lang:mainfrom
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
rustbot
added
the
T-libs
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
This was referenced Jan 19, 2026
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
unsafe-unpin-opsem
branch
from
faea4bb to
ee603cd
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
unsafe-unpin-opsem
branch
from
ee603cd to
296a434
Compare
Collaborator
|
This PR modifies cc @jieyouxu |
rustbot
added
the
A-test-infra-minicore
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Uh, what is happening with the link checker here? I have no idea why this PR would add new links to |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Uh, no idea what's going on, but it some sort of rustdoc weirdness... Cc @rust-lang/rustdoc |
RalfJung
force-pushed
the
unsafe-unpin-opsem
branch
from
e978d76 to
ba96ef7
Compare
rustbot
added
the
T-rustdoc-frontend
RalfJung
force-pushed
the
unsafe-unpin-opsem
branch
from
ba96ef7 to
860c3a8
Compare
Member
Author
|
@davidtwco will you be fine to review this or should I go look for someone else? Not sure who else knows their way around our LLVM attribute handling here... @nikic @workingjubilee maybe? |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@rustbot reroll |
RalfJung
force-pushed
the
unsafe-unpin-opsem
branch
from
860c3a8 to
8a4619e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Sorry for the delay in getting back to you, some of this is a bit out of cache for me, so probably best to reroll. |
Member
Author
|
@rustbot reroll |
RalfJung
force-pushed
the
unsafe-unpin-opsem
branch
from
8a4619e to
0cbe1cc
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 14, 2026
…yUwU UnsafePinned: implement opsem effects of UnsafeUnpin This implements the next step for rust-lang#125735: actually making `UnsafePinned` have special opsem effects by suppressing the `noalias` *even if* the type is wrapped in an `Unpin` wrapper. For backwards compatibility we also still keep the `Unpin` hack, i.e. a type must be both `Unpin` and `UnsafeUnpin` to get `noalias`.
This was referenced Feb 14, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
…uwer Rollup of 7 pull requests Successful merges: - #152622 (Update GCC subtree) - #145024 (Optimize indexing slices and strs with inclusive ranges) - #151365 (UnsafePinned: implement opsem effects of UnsafeUnpin) - #152381 (Do not require `'static` for obtaining reflection information.) - #143575 (Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s) - #152404 (tests: adapt align-offset.rs for InstCombine improvements in LLVM 23) - #152582 (rustc_query_impl: Use `ControlFlow` in `visit_waiters` instead of nested options)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
…uwer Rollup of 7 pull requests Successful merges: - #152622 (Update GCC subtree) - #145024 (Optimize indexing slices and strs with inclusive ranges) - #151365 (UnsafePinned: implement opsem effects of UnsafeUnpin) - #152381 (Do not require `'static` for obtaining reflection information.) - #143575 (Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s) - #152404 (tests: adapt align-offset.rs for InstCombine improvements in LLVM 23) - #152582 (rustc_query_impl: Use `ControlFlow` in `visit_waiters` instead of nested options)
rust-timer
added a commit
that referenced
this pull request
Feb 15, 2026
Rollup merge of #151365 - RalfJung:unsafe-unpin-opsem, r=BoxyUwU UnsafePinned: implement opsem effects of UnsafeUnpin This implements the next step for #125735: actually making `UnsafePinned` have special opsem effects by suppressing the `noalias` *even if* the type is wrapped in an `Unpin` wrapper. For backwards compatibility we also still keep the `Unpin` hack, i.e. a type must be both `Unpin` and `UnsafeUnpin` to get `noalias`.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Feb 15, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#152622 (Update GCC subtree) - rust-lang/rust#145024 (Optimize indexing slices and strs with inclusive ranges) - rust-lang/rust#151365 (UnsafePinned: implement opsem effects of UnsafeUnpin) - rust-lang/rust#152381 (Do not require `'static` for obtaining reflection information.) - rust-lang/rust#143575 (Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s) - rust-lang/rust#152404 (tests: adapt align-offset.rs for InstCombine improvements in LLVM 23) - rust-lang/rust#152582 (rustc_query_impl: Use `ControlFlow` in `visit_waiters` instead of nested options)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the next step for #125735: actually making
UnsafePinnedhave special opsem effects by suppressing thenoaliaseven if the type is wrapped in anUnpinwrapper.For backwards compatibility we also still keep the
Unpinhack, i.e. a type must be bothUnpinandUnsafeUnpinto getnoalias.